fix(test): do not assert a POSIX execute bit on Windows - #119
Merged
Conversation
test_install_writes_verified_files_and_a_receipt asserted st_mode & 0o100 on the installed ffmpeg. Windows has no execute bit: st_mode is 0o666 or 0o444 there and chmod only toggles read-only, so the assertion could never hold and test-windows went red on main after #118. The install-and-encode lane in ffmpeg-pin.yml already proves the installed runtime actually runs on windows-latest, which is the property this assertion was reaching for. Keep the mode checks on POSIX and check readability on Windows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
abrichr
added a commit
that referenced
this pull request
Aug 28, 2026
#118 and #119 landed after the 1.3.0 section was written, so the notes did not mention them. #118 in particular adds a user-facing command and a network fetch, which the notes must state. The FFmpeg entry says plainly that neither artifact carries FFmpeg bytes and that nothing downloads unless the operator asks. Verified against the built wheel and source archive rather than taken from the commit message. The version stays 1.3.0. The highest bump implied since v1.2.2 is still minor, and 1.3.0 is already the minor. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-windowswent red on main after #118.test_install_writes_verified_files_and_a_receiptassertedst_mode & 0o100on the installed ffmpeg. Windows has no execute bit.
st_modereads0o666or0o444there andchmodonly toggles the read-only flag, so the assertioncould never hold on that platform.
The installer itself is fine on Windows.
ffmpeg-pin.yml's install-and-encodelane passed on
windows-latestin #118: it downloads the pinned archive,verifies every digest, installs, and runs a real encode-and-decode probe. That
lane proves the property this assertion was reaching for.
So the mode checks stay on POSIX, where they mean something, and Windows checks
readability instead. The digest-ordering test is untouched and still runs on
every platform.
🤖 Generated with Claude Code